linux-kernel - Re: [PATCH] staging: greybus: replace WD_STATE_COLDBOOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026010547-slacks-comic-bc68@gregkh>
Date: Mon, 5 Jan 2026 07:21:12 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Gideon Adjei <gideonadjei.dev@...il.com>
Cc: Vaibhav Hiremath <hvaibhav.linux@...il.com>,
	Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
	greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: replace WD_STATE_COLDBOOT_TRIG with
 state

On Sun, Jan 04, 2026 at 05:25:41AM -0800, Gideon Adjei wrote:
> use state temporary variable to replace WD_STATE_COLDBOOT_TRIG argument
> in arche_platform_set_wake_detect_state. This keeps lines under 80
> columns and satisfies kernel style guidelines.
> 
> Signed-off-by: Gideon Adjei <gideonadjei.dev@...il.com>
> ---
>  drivers/staging/greybus/arche-platform.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index 8aaff4e45660..bb9b3c3c7a2d 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -155,6 +155,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  {
>  	struct arche_platform_drvdata *arche_pdata = devid;
>  	unsigned long flags;
> +	int state;
>  
>  	spin_lock_irqsave(&arche_pdata->wake_lock, flags);
>  
> @@ -179,8 +180,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  				 */
>  				if (arche_pdata->wake_detect_state !=
>  						WD_STATE_COLDBOOT_START) {
> -					arche_platform_set_wake_detect_state(arche_pdata,
> -									     WD_STATE_COLDBOOT_TRIG);
> +					state = WD_STATE_COLDBOOT_TRIG;
> +					arche_platform_set_wake_detect_state(arche_pdata, state);

No, sorry, the original code here is just fine, don't do things like
this just to make checkpatch "quiet".

thanks,

greg k-h