linux-kernel - Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026010520-quickness-humble-70db@gregkh>
Date: Mon, 5 Jan 2026 07:25:51 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Danilo Krummrich <dakr@...nel.org>, sashal@...nel.org,
	Marko Turk <mt@...koturk.info>, Dirk Behme <dirk.behme@...il.com>,
	dirk.behme@...bosch.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment

On Sun, Jan 04, 2026 at 07:30:22PM +0100, Miguel Ojeda wrote:
> On Sun, Jan 4, 2026 at 3:08 PM Danilo Krummrich <dakr@...nel.org> wrote:
> >
> > In general I prefer to only add a Fixes: tag for the commit that introduced the
> > issue.
> 
> If their scripts track moves well, then it is great to avoid it, but I
> am not sure how well that works or not or in which cases, i.e. it
> could look like two different commits introduced the issue and thus
> one backport could be missed. Not sure.
> 
> > Again, I could also remember this wrongly, but I think I just recently reviewed
> > such a commit from Sasha. :)
> 
> Hmm... I also had a few cases where Sasha autoapplied, but in most
> cases, I had to provide custom patches when they didn't apply cleanly,
> even trivial ones.

It all depends, sometimes we can handle file moves easily, sometimes we
can not.

But really, why is a comment typo being needed in stable kernels?

thanks,

greg k-h