linux-kernel - Re: [PATCH 07/12] i2c: st: set device parent and of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92c8b930-adc2-4204-b9c1-0dc1e31115f3@foss.st.com>
Date: Mon, 5 Jan 2026 08:26:02 +0100
From: Patrice CHOTARD <patrice.chotard@...s.st.com>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>, Wolfram Sang
	<wsa+renesas@...g-engineering.com>, Mukesh Kumar Savaliya
	<mukesh.savaliya@....qualcomm.com>, Viken Dadhaniya
	<viken.dadhaniya@....qualcomm.com>, Andi Shyti <andi.shyti@...nel.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui
	<rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, "Broadcom
 internal kernel review list" <bcm-kernel-feedback-list@...adcom.com>, Vignesh
 R <vigneshr@...com>, Aaro Koskinen <aaro.koskinen@....fi>, Janusz Krzysztofik
	<jmkrzyszt@...il.com>, Tony Lindgren <tony@...mide.com>, Andreas Kemnade
	<andreas@...nade.info>, Kevin Hilman <khilman@...libre.com>, Roger Quadros
	<rogerq@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, "Magnus
 Damm" <magnus.damm@...il.com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
	<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Linus Walleij <linusw@...nel.org>
CC: Bartosz Golaszewski <brgl@...nel.org>, <linux-i2c@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <imx@...ts.linux.dev>,
	<linux-rpi-kernel@...ts.infradead.org>
Subject: Re: [PATCH 07/12] i2c: st: set device parent and of_node through the
 adapter struct



On 12/23/25 11:04, Bartosz Golaszewski wrote:
> Configure the parent device and the OF-node using dedicated fields in
> struct i2c_adapter and avoid dereferencing the internal struct device.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
> ---
>  drivers/i2c/busses/i2c-st.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index 97d70e66722706f242cd97153387c3a865abc12d..b50be2c39eaa4b9b95a71b038a4d63f3c5fd7c4b 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -849,8 +849,8 @@ static int st_i2c_probe(struct platform_device *pdev)
>  	adap->retries = 0;
>  	adap->algo = &st_i2c_algo;
>  	adap->bus_recovery_info = &st_i2c_recovery_info;
> -	adap->dev.parent = &pdev->dev;
> -	adap->dev.of_node = pdev->dev.of_node;
> +	adap->parent = &pdev->dev;
> +	adap->of_node = pdev->dev.of_node;
>  
>  	init_completion(&i2c_dev->complete);
>  
> 
Reviewed-by: Patrice Chotard <patrice.chotard@...s.st.com>

Thanks
Patrice