linux-kernel - Re: [PATCH 4/7] mtd: rawnand: qcom: Simplify with scoped for each OF child loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yy6nfsezapap7o2pnbydczoh6376crzr33oibkuwonygxnhsky@ongy4c6cy67m>
Date: Mon, 5 Jan 2026 13:15:45 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: Brian Norris <computersforpeace@...il.com>, 
	Kamal Dasu <kamal.dasu@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Miquel Raynal <miquel.raynal@...tlin.com>, 
	Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, 
	Harvey Hunt <harveyhuntnexus@...il.com>, Paul Cercueil <paul@...pouillou.net>, 
	Stefan Agner <stefan@...er.ch>, Tudor Ambarus <tudor.ambarus@...aro.org>, 
	Pratyush Yadav <pratyush@...nel.org>, Michael Walle <mwalle@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <nick.desaulniers+lkml@...il.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, 
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH 4/7] mtd: rawnand: qcom: Simplify with scoped for each OF
 child loop

On Fri, Jan 02, 2026 at 01:49:31PM +0100, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

- Mani

> ---
>  drivers/mtd/nand/raw/qcom_nandc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 4dd6f1a4e797..b7e79b76654d 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -2206,16 +2206,14 @@ static int qcom_nand_host_init_and_register(struct qcom_nand_controller *nandc,
>  static int qcom_probe_nand_devices(struct qcom_nand_controller *nandc)
>  {
>  	struct device *dev = nandc->dev;
> -	struct device_node *dn = dev->of_node, *child;
> +	struct device_node *dn = dev->of_node;
>  	struct qcom_nand_host *host;
>  	int ret = -ENODEV;
>  
> -	for_each_available_child_of_node(dn, child) {
> +	for_each_available_child_of_node_scoped(dn, child) {
>  		host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
> -		if (!host) {
> -			of_node_put(child);
> +		if (!host)
>  			return -ENOMEM;
> -		}
>  
>  		ret = qcom_nand_host_init_and_register(nandc, host, child);
>  		if (ret) {
> -- 
> 2.51.0
> 

-- 
மணிவண்ணன் சதாசிவம்