linux-kernel - Re: [PATCH v4 1/5] dt-bindings: soc: spacemit: k3: add clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260105075510-GYA2078702@gentoo.org>
Date: Mon, 5 Jan 2026 15:55:10 +0800
From: Yixun Lan <dlan@...too.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Stephen Boyd <sboyd@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Haylen Chu <heylenay@....org>,
	Guodong Xu <guodong@...cstar.com>,
	Inochi Amaoto <inochiama@...il.com>, Yao Zi <me@...ao.cc>,
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/5] dt-bindings: soc: spacemit: k3: add clock support

Hi Krzysztof,

On 08:48 Mon 05 Jan     , Krzysztof Kozlowski wrote:
> On Sat, Jan 03, 2026 at 03:44:16PM +0800, Yixun Lan wrote:
> > Add compatible strings for clock drivers to support Spacemit K3 SoC,
> > also includes all the defined clock IDs.
> > 
> > The SpacemiT K3 SoC clock IP is scattered over several different blocks,
> > which are APBC, APBS, APMU, DCIU, MPMU, all of them are capable of
> > generating clock and reset signals. APMU and MPMU have additional Power
> > Domain management functionality.
> > 
> > Following is a brief list that shows devices managed in each block:
> > 
> > APBC: UART, GPIO, PWM, SPI, TIMER, I2S, IR, DR, TSEN, IPC, CAN
> > APBS: various PPL clocks control
> > APMU: CCI, CPU, CSI, ISP, LCD, USB, QSPI, DMA, VPU, GPU, DSI, PCIe, EMAC..
> > DCID: SRAM, DMA, TCM
> > MPMU: various PLL1 derived clocks, UART, WATCHDOG, I2S
> > 
> > Signed-off-by: Yixun Lan <dlan@...too.org>
> > ---
..
> > @@ -28,7 +30,7 @@ properties:
> >    "#clock-cells":
> >      const: 1
> >      description:
> > -      See <dt-bindings/clock/spacemit,k1-syscon.h> for valid indices.
> > +      See corresponding file under <dt-bindings/clock/> for valid indices.
> 
> List two paths, better. Generic path to clock directory is obvious and
> not helping.
> 
ok, will do

> > @@ -39,7 +43,7 @@ properties:
> >    "#clock-cells":
> >      const: 1
> >      description:
> > -      See <dt-bindings/clock/spacemit,k1-syscon.h> for valid indices.
> > +      See corresponding file under <dt-bindings/clock/> for valid indices.
> 
> Same problem here.
> 
ditto

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> 
thanks, I will wait few days for incoming reviews, then update

> Best regards,
> Krzysztof
> 

-- 
Yixun Lan (dlan)