linux-kernel - Re: [PATCH] lib/crypto: tests: polyval_kunit: Increase iterations for preparekey in IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260105092043-d18628ec-a42a-490b-8bbf-d611dd5afb5a@linutronix.de>
Date: Mon, 5 Jan 2026 09:21:32 +0100
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: Eric Biggers <ebiggers@...nel.org>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>, 
	Ard Biesheuvel <ardb@...nel.org>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/crypto: tests: polyval_kunit: Increase iterations
 for preparekey in IRQs

On Fri, Jan 02, 2026 at 10:27:48AM -0800, Eric Biggers wrote:
> On Fri, Jan 02, 2026 at 08:32:03AM +0100, Thomas Weißschuh wrote:
> > On my development machine the generic, memcpy()-only implementation of
> > polyval_preparekey() is too fast for the IRQ workers to actually fire.
> > The test fails.
> > 
> > Increase the iterations to make the test more robust.
> > The test will run for a maximum of one second in any case.
> > 
> > Fixes: b3aed551b3fc ("lib/crypto: tests: Add KUnit tests for POLYVAL")
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> 
> Glad to see that people are running these tests!  I actually already
> applied
> https://lore.kernel.org/linux-crypto/20251219085259.1163048-1-davidgow@google.com/
> for this issue, which should be sufficient by itself.

That works, too. Thanks!

> Might be worth
> increasing the iteration count as well, but I'd like to check whether
> any other tests could use a similar change as well.

No other one of the default tests failed for me in a similar way.


Thomas