linux-kernel - Re: [PATCH v2] uvcvideo: simplify spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260105093512.194988-1-chenchangcheng@kylinos.cn>
Date: Mon,  5 Jan 2026 17:35:12 +0800
From: Chen Changcheng <chenchangcheng@...inos.cn>
To: krzk@...nel.org
Cc: chenchangcheng@...inos.cn,
	hansg@...nel.org,
	laurent.pinchart@...asonboard.com,
	linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	mchehab@...nel.org
Subject: Re: [PATCH v2] uvcvideo: simplify spin_lock using guards

> This is an undesired syntax explicitly documented as one to avoid. You
> need here proper assignment, not NULL. Please don't use cleanup.h if you
> do not intend to follow it because it does not make the code simpler.

Thank you for your correction and feedback. I made the change initially
because I saw similar patterns using "__free(...) = NULL" in patches from
other driver modules, which led me to overlook the core paradigm of
cleanup.h that requires a "declaration with a meaningful initializer."

Best regards,
Changcheng Chen