linux-kernel - Re: [PATCH] ARM: omap2: Fix reference count leaks in omap_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260105102704.77d4c9d1@kemnade.info>
Date: Mon, 5 Jan 2026 10:27:04 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: aaro.koskinen@....fi, khilman@...libre.com, rogerq@...nel.org,
 tony@...mide.com, linux@...linux.org.uk,
 linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ARM: omap2: Fix reference count leaks in
 omap_control_init()

On Wed, 17 Dec 2025 14:21:22 +0000
Wentao Liang <vulab@...as.ac.cn> wrote:

> The of_get_child_by_name() function increments the reference count
> of child nodes, causing multiple reference leaks in omap_control_init():
> 
> 1. scm_conf node never released in normal/error paths
> 2. clocks node leak when checking existence
> 3. Missing scm_conf release before np in error paths
> 
> Fix these leaks by adding proper of_node_put() calls and separate error
> handling.
> 
> Fixes: e5b635742e98 ("ARM: OMAP2+: control: add syscon support for register accesses")
> Cc: stable@...r.kernel.org
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>

Reviewed-by: Andreas Kemnade <andreas@...nade.info>