linux-kernel - Re: [PATCH v2] platform/x86: yogabook: Clean up code style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ae5bbfdb-5a93-4f7b-b553-86014e6a2029@app.fastmail.com>
Date: Sun, 04 Jan 2026 21:14:14 -0500
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: "Benjamin Philip" <benjamin.philip495@...il.com>,
 "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Cc: "Derek J . Clark" <derekjohn.clark@...il.com>,
 "Hans de Goede" <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH v2] platform/x86: yogabook: Clean up code style



On Thu, Jan 1, 2026, at 9:16 AM, Benjamin Philip wrote:
> This commit cleans up the following checks flagged by checkpatch in
> yogabook.c:
>
> - CHECK: Prefer kernel type 'u8' over 'uint8_t'
> - CHECK: Comparison to NULL could be written "!data"
> - CHECK: line length of ... exceeds 100 columns
>
> Signed-off-by: Benjamin Philip <benjamin.philip495@...il.com>
> ---
> Changes in v2:
>   - Drop cleanup for "CHECK: Unnecessary parentheses around '...'" 
>
>  drivers/platform/x86/lenovo/yogabook.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/yogabook.c 
> b/drivers/platform/x86/lenovo/yogabook.c
> index 31b298dc5046..69887de36c9b 100644
> --- a/drivers/platform/x86/lenovo/yogabook.c
> +++ b/drivers/platform/x86/lenovo/yogabook.c
> @@ -57,7 +57,7 @@ struct yogabook_data {
>  	struct work_struct work;
>  	struct led_classdev kbd_bl_led;
>  	unsigned long flags;
> -	uint8_t brightness;
> +	u8 brightness;
>  };
> 
>  static void yogabook_work(struct work_struct *work)
> @@ -338,16 +338,18 @@ static int yogabook_wmi_probe(struct wmi_device 
> *wdev, const void *context)
>  	int r;
> 
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> -	if (data == NULL)
> +	if (!data)
>  		return -ENOMEM;
> 
>  	data->kbd_adev = acpi_dev_get_first_match_dev("GDIX1001", NULL, -1);
>  	if (!data->kbd_adev)
> -		return dev_err_probe(dev, -ENODEV, "Cannot find the touchpad device 
> in ACPI tables\n");
> +		return dev_err_probe(dev, -ENODEV,
> +				     "Cannot find the touchpad device in ACPI tables\n");
> 
>  	data->dig_adev = acpi_dev_get_first_match_dev("WCOM0019", NULL, -1);
>  	if (!data->dig_adev) {
> -		r = dev_err_probe(dev, -ENODEV, "Cannot find the digitizer device in 
> ACPI tables\n");
> +		r = dev_err_probe(dev, -ENODEV,
> +				  "Cannot find the digitizer device in ACPI tables\n");
>  		goto error_put_devs;
>  	}
> 
> @@ -453,7 +455,7 @@ static int yogabook_pdev_probe(struct platform_device *pdev)
>  	int r;
> 
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> -	if (data == NULL)
> +	if (!data)
>  		return -ENOMEM;
> 
>  	data->kbd_dev = bus_find_device_by_name(&i2c_bus_type, NULL, "i2c-goodix_ts");
> -- 
> 2.52.0

Looks good to me. Thanks!
Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>

Mark