linux-kernel - Re: [PATCH 04/11] rust: macros: use `syn` to parse `module!` macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260105022029.5226137c.gary@garyguo.net>
Date: Mon, 5 Jan 2026 02:20:29 +0000
From: Gary Guo <gary@...yguo.net>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
 <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl
 <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich
 <dakr@...nel.org>, Fiona Behrens <me@...enk.dev>, Patrick Miller
 <paddymills@...ton.me>, José Expósito
 <jose.exposito89@...il.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Guilherme Giacomo Simoes
 <trintaeoitogc@...il.com>, rust-for-linux@...r.kernel.org, Igor Korotin
 <igor.korotin.linux@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/11] rust: macros: use `syn` to parse `module!` macro

On Sun, 4 Jan 2026 17:53:04 -0500
Tamir Duberstein <tamird@...il.com> wrote:

> On Thu, Dec 11, 2025 at 2:29 PM Gary Guo <gary@...nel.org> wrote:
> >
> > From: Gary Guo <gary@...yguo.net>
> > 
> > +enum ModInfoField {
> > +    Type(Token![type], Token![:], Ident),
> > +    Name(kw::name, Token![:], AsciiLitStr),
> > +    Authors(
> > +        kw::authors,
> > +        Token![:],
> > +        Bracket,
> > +        Punctuated<LitStr, Token![,]>,
> > +    ),  
> 
> Per the documentation on macros::module, authors must be ASCII.

Ah, I am mislead by the helper name, thinking that the current impl
supports Unicode. To be fair, author names should support unicode (we
previously use ASCII mostly because we don't want to do many parsing
and escaping).

However I'll leave it to a future patch and keep things ASCII for this
series in the new version.

> 
> > +    Description(kw::description, Token![:], LitStr),
> > +    License(kw::license, Token![:], AsciiLitStr),
> > +    Alias(
> > +        kw::authors,  
> 
> This should be kw::alias

Good catch.

Best,
Gary

> 
> > +        Token![:],
> > +        Bracket,
> > +        Punctuated<LitStr, Token![,]>,
> > +    ),  
> 
> Per the documentation on macros::module, alias must be ASCII.
> 
> > +    Firmware(
> > +        kw::firmware,
> > +        Token![:],
> > +        Bracket,
> > +        Punctuated<LitStr, Token![,]>,
> > +    ),  
> 
> Must be ASCII.
>