linux-kernel - Re: [PATCH v3] drm/bridge: synopsys: dw-dp: fix error paths of dw_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFGM64QKX8QF.28OD6W8F3JEJ8@bootlin.com>
Date: Mon, 05 Jan 2026 12:20:30 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: "Osama Abdelkader" <osama.abdelkader@...il.com>, "Andy Yan"
 <andy.yan@...k-chips.com>
Cc: <stable@...r.kernel.org>, "Andrzej Hajda" <andrzej.hajda@...el.com>,
 "Neil Armstrong" <neil.armstrong@...aro.org>, "Robert Foss"
 <rfoss@...nel.org>, "Laurent Pinchart" <Laurent.pinchart@...asonboard.com>,
 "Jonas Karlman" <jonas@...boo.se>, "Jernej Skrabec"
 <jernej.skrabec@...il.com>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Dmitry Baryshkov"
 <dmitry.baryshkov@....qualcomm.com>, <dri-devel@...ts.freedesktop.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] drm/bridge: synopsys: dw-dp: fix error paths of
 dw_dp_bind

Hello Osama,

On Fri Jan 2, 2026 at 4:55 PM CET, Osama Abdelkader wrote:
> Fix several issues in dw_dp_bind() error handling:
>
> 1. Missing return after drm_bridge_attach() failure - the function
>    continued execution instead of returning an error.
>
> 2. Resource leak: drm_dp_aux_register() is not a devm function, so
>    drm_dp_aux_unregister() must be called on all error paths after
>    aux registration succeeds. This affects errors from:
>    - drm_bridge_attach()
>    - phy_init()
>    - devm_add_action_or_reset()
>    - platform_get_irq()
>    - devm_request_threaded_irq()
>
> 3. Bug fix: platform_get_irq() returns the IRQ number or a negative
>    error code, but the error path was returning ERR_PTR(ret) instead
>    of ERR_PTR(dp->irq).
>
> Use a goto label for cleanup to ensure consistent error handling.
>
> Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
> Cc: stable@...r.kernel.org
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@...il.com>

Thank you for the improvements!

Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com