linux-kernel - Re: [PATCH] pci: controller: tegra194: remove dependency on Tegra194 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44fc1031-14e4-4340-a4b8-74fe524c3ee0@nvidia.com>
Date: Mon, 5 Jan 2026 11:55:00 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: Francesco Lavra <flavra@...libre.com>, thierry.reding@...il.com,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Mayank Rana <mayank.rana@....qualcomm.com>,
 Thomas Gleixner <tglx@...utronix.de>, Shradha Todi <shradha.t@...sung.com>,
 Thippeswamy Havalige <thippeswamy.havalige@....com>,
 Inochi Amaoto <inochiama@...il.com>, Vidya Sagar <vidyas@...dia.com>,
 linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
 "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] pci: controller: tegra194: remove dependency on Tegra194
 SoC



On 05/01/2026 08:39, Manivannan Sadhasivam wrote:
> On Fri, Jan 02, 2026 at 10:58:15AM +0000, Jon Hunter wrote:
>>
>> On 23/12/2025 06:45, Manivannan Sadhasivam wrote:
>>> On Wed, Nov 26, 2025 at 11:25:30AM +0100, Francesco Lavra wrote:
>>>
>>> + Tegra maintainers
>>>
>>>> This driver runs (for both host and endpoint operation) also on other Tegra
>>>> SoCs (e.g. Tegra234).
>>>> Replace the Kconfig dependency on ARCH_TEGRA_194_SOC with a more generic
>>>> dependency on ARCH_TEGRA; in addition, amend the Kconfig help text to
>>>> reflect the fact that this driver is no longer exclusive to Tegra194.
>>>>
>>>
>>> I vaguely remember asking about this a while back during some other patch review
>>> and I don't remember what we concluded.
>>>> Thierry, Jon, thoughts?
>>
>> So ARCH_TEGRA means that this can be enabled for the legacy 32-bit Tegra
>> devices as well as the current 64-bit Tegra devices (such as Tegra194).
>> Given that this driver is only used for Tegra194 and Tegra234, it seems it
>> would be better to only enable this for Tegra194 and Tegra234 instead of any
>> Tegra.
>>
> 
> The dependency means, whenever someone tries to enable PCIE_TEGRA194_HOST,
> ARCH_TEGRA should be enabled. So as long as someone not trying to enable
> PCIE_TEGRA194_HOST for 32bit Tegra systems, ARCH_TEGRA should work fine and
> PCIE_TEGRA194_HOST is not selected by arch/arm/configs/tegra_defconfig. So I
> don't see any blocker with this patch. In fact, many other archs do the same.
> 
> But I don't like extending the Kconfig with per SoC dependency as it won't
> scale.

Yes normally it does not. However, in this case it will only be used for 
Tegra194 and Tegra234 and not any later devices.

Jon

-- 
nvpublic