linux-kernel - Re: [PATCH v2 2/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96e317a1-d564-4c66-b71c-ea03acc20ce7@kernel.org>
Date: Mon, 5 Jan 2026 13:01:43 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: weifu wu <wwfu06@....com>, andersson@...nel.org, konradybcio@...nel.org
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11

On 05/01/2026 12:04, weifu wu wrote:
> Add DT binding documentation for Acer Swift SFA14-11 laptop based on Qualcomm X1E78100 SoC.

Can you please slow down and address the feedback? EACH one.

> This introduces a new compatible string for the Acer Swift SFA14-11 board.

Drop, redundant.

> 
> Eliminate duplicate data and add the device model to the compatible entry.

Not relevant.

> 
> Signed-off-by: weifu wu <wwfu06@....com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 55d4afa9a70e..09c488973961 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1068,12 +1068,6 @@ properties:
>        - items:
>            - enum:
>                - acer,swift-sfa14-11
> -          - const: acer,swift-sfa14-11
> -          - const: qcom,x1e78100
> -          - const: qcom,x1e80100

There is no such hunk.

Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46


Best regards,
Krzysztof