linux-kernel - Re: [PATCH] pci: controller: tegra194: remove dependency on Tegra194 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVus2urjJ3AoHMv3@ryzen>
Date: Mon, 5 Jan 2026 13:21:46 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: Jon Hunter <jonathanh@...dia.com>,
	Francesco Lavra <flavra@...libre.com>, thierry.reding@...il.com,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Mayank Rana <mayank.rana@....qualcomm.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Shradha Todi <shradha.t@...sung.com>,
	Thippeswamy Havalige <thippeswamy.havalige@....com>,
	Inochi Amaoto <inochiama@...il.com>,
	Vidya Sagar <vidyas@...dia.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] pci: controller: tegra194: remove dependency on Tegra194
 SoC

On Mon, Jan 05, 2026 at 01:14:01PM +0100, Niklas Cassel wrote:
> > > > So, I think we could just merge:
> > > > https://lore.kernel.org/linux-pci/20250508051922.4134041-1-vidyas@nvidia.com/
> > > > 
> > > > (Assuming it still applies.)
> > > 
> > > Yes it does and applying Sagar's patch is fine with me. So it you want to
> > > apply Sagar's patch please add my ...
> > > 
> > 
> > Don't we need:
> > 
> > 	depends on (ARCH_TEGRA && ARM64) || COMPILE_TEST
> 
> This is exactly what I originally suggested to Vidya:
> https://lore.kernel.org/linux-pci/Z6XjWJd9jm0HHNXW@ryzen/
> 
> 
> > 
> > in the above patch?
> 
> The above patch instead has:
> 
> depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
> 
> I don't know why Vidya did not use my suggestion exactly, but I guess I
> assumed that he had a reason not to use my suggestion exactly.


Looking at drivers/pci/controller/dwc/Kconfig,
there are a lot of:

depends on OF && (ARM64 || COMPILE_TEST)

So I think Vidya simply followed this pattern and instead did:
depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)


But, since we don't have an explicit "depends on OF"
in these entries, I do think that:

depends on (ARCH_TEGRA && ARM64) || COMPILE_TEST

is slightly more correct. (Since if there was a hard requirement on OF,
it would have been there already).


Kind regards,
Niklas