[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aVutHsTCcHgt7qHk@tiehlicka>
Date: Mon, 5 Jan 2026 13:22:54 +0100
From: Michal Hocko <mhocko@...e.com>
To: Dipendra Khadka <kdipendra88@...il.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, rientjes@...gle.com, shakeel.butt@...ux.dev
Subject: Re: [PATCH] mm/oom_kill: Remove unnecessary integer promotion in
format string
On Wed 31-12-25 12:21:17, Dipendra Khadka wrote:
[...]
> Checkpatch flags the 'h' modifier as unnecessary for this reason,
> and many other subsystems have moved to using %d for promoted types.
> Hence, I think this patch aligns with kernel coding practices.
And here, this is the actual argument to push change like that. On its
own this is not really worth it. But if there is a general push to
remove %hd then sure change like this makes us closer to do that and
quite honestly I am not a great fan of %hd. I will not miss it.
Please update the changelog and then feel free to add
Acked-by: Michal Hocko <mhocko@...e.com>
Thanks!
--
Michal Hocko
SUSE Labs
Powered by blists - more mailing lists