linux-kernel - Re: [PATCH v1 04/23] drm/imagination: Discard pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d7a7712-7a09-4978-a1eb-73282934bd74@imgtec.com>
Date: Mon, 5 Jan 2026 12:29:53 +0000
From: Matt Coster <Matt.Coster@...tec.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
CC: Ulf Hansson <ulf.hansson@...aro.org>,
        Brian Norris
	<briannorris@...omium.org>,
        Frank Binns <Frank.Binns@...tec.com>,
        Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Frank Binns
	<Frank.Binns@...tec.com>,
        Alessio Belle <Alessio.Belle@...tec.com>,
        Alexandru
 Dadu <Alexandru.Dadu@...tec.com>,
        "linux-pm@...r.kernel.org"
	<linux-pm@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 04/23] drm/imagination: Discard pm_runtime_put() return
 value

On 22/12/2025 19:59, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The Imagination DRM driver defines pvr_power_put() to pass the return
> value of pm_runtime_put() to the caller, but then it never uses the
> return value of pvr_power_put().
> 
> Modify pvr_power_put() to discard the pm_runtime_put() return value and
> change its return type to void.
> 
> No intentional functional impact.
> 
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Hi Rafael,

Apologies for the late reply, I was on holiday. If this hasn't already
landed, feel free to add:

Reviewed-by: Matt Coster <matt.coster@...tec.com>

Cheers,
Matt

> ---
> 
> This patch is part of a series, but it doesn't depend on anything else
> in that series.  The last patch in the series depends on it.
> 
> It can be applied by itself and if you decide to do so, please let me
> know.
> 
> Otherwise, an ACK or equivalent will be appreciated, but also the lack
> of specific criticism will be eventually regarded as consent.
> 
> ---
>  drivers/gpu/drm/imagination/pvr_power.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/gpu/drm/imagination/pvr_power.h
> +++ b/drivers/gpu/drm/imagination/pvr_power.h
> @@ -30,12 +30,12 @@ pvr_power_get(struct pvr_device *pvr_dev
>  	return pm_runtime_resume_and_get(drm_dev->dev);
>  }
>  
> -static __always_inline int
> +static __always_inline void
>  pvr_power_put(struct pvr_device *pvr_dev)
>  {
>  	struct drm_device *drm_dev = from_pvr_device(pvr_dev);
>  
> -	return pm_runtime_put(drm_dev->dev);
> +	pm_runtime_put(drm_dev->dev);
>  }
>  
>  int pvr_power_domains_init(struct pvr_device *pvr_dev);
> 
> 
> 

-- 
Matt Coster
E: matt.coster@...tec.com


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)