linux-kernel - Re: [PATCH] x86/CPU/AMD: Simplify the spectral chicken fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2eee3670-6e0a-4f7d-8f6a-5226547bfe6e@suse.com>
Date: Mon, 5 Jan 2026 15:20:35 +0200
From: Nikolay Borisov <nik.borisov@...e.com>
To: Borislav Petkov <bp@...nel.org>, X86 ML <x86@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, "Borislav Petkov (AMD)"
 <bp@...en8.de>
Subject: Re: [PATCH] x86/CPU/AMD: Simplify the spectral chicken fix



On 30.12.25 г. 13:07 ч., Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@...en8.de>
> 
> msr_set_bit() takes a bit number to set but MSR_ZEN2_SPECTRAL_CHICKEN_BIT
> is a bit mask. The usual pattern that code uses is a _BIT-named type
> macro instead of a mask.
> 
> So convert it to a bit number to reflect that.
> 
> Also, msr_set_bit() already does the reading and checking whether the
> bit needs to be set so use that instead of a local variable.
> 
> Fixup tabbing while at it.
> 
> No functional changes.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>


Reviewed-by: Nikolay Borisov <nik.borisov@...e.com>