linux-kernel - Re: [PATCH v4 2/3] of: factor arguments passed to of_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202601062128.BCmw1wNO-lkp@intel.com>
Date: Tue, 6 Jan 2026 21:58:53 +0800
From: kernel test robot <lkp@...el.com>
To: Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>,
	robin.murphy@....com, will@...nel.org, joro@...tes.org,
	robh@...nel.org, dmitry.baryshkov@....qualcomm.com,
	konrad.dybcio@....qualcomm.com, bjorn.andersson@....qualcomm.com,
	bod@...nel.org, conor+dt@...nel.org, krzk+dt@...nel.org,
	saravanak@...gle.com, prakash.gupta@....qualcomm.com,
	vikash.garodia@....qualcomm.com
Cc: oe-kbuild-all@...ts.linux.dev, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Charan Teja Kalla <charan.kalla@....qualcomm.com>,
	Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>
Subject: Re: [PATCH v4 2/3] of: factor arguments passed to of_map_id() into a
 struct

Hi Vijayanand,

kernel test robot noticed the following build warnings:

[auto build test WARNING on xen-tip/linux-next]
[cannot apply to robh/for-next pci/next pci/for-linus linus/master v6.19-rc4 next-20260106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vijayanand-Jitta/of-Add-convenience-wrappers-for-of_map_id/20251231-194928
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
patch link:    https://lore.kernel.org/r/20251231114257.2382820-3-vijayanand.jitta%40oss.qualcomm.com
patch subject: [PATCH v4 2/3] of: factor arguments passed to of_map_id() into a struct
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20260106/202601062128.BCmw1wNO-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260106/202601062128.BCmw1wNO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601062128.BCmw1wNO-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/cdx/cdx_msi.c:8:
   In function 'of_map_msi_id',
       inlined from 'cdx_msi_prepare' at drivers/cdx/cdx_msi.c:131:8:
>> include/linux/of.h:1451:30: warning: 'dev_id' is used uninitialized [-Wuninitialized]
    1451 |         struct of_map_id_arg arg = {
         |                              ^~~
   drivers/cdx/cdx_msi.c: In function 'cdx_msi_prepare':
   drivers/cdx/cdx_msi.c:127:13: note: 'dev_id' was declared here
     127 |         u32 dev_id;
         |             ^~~~~~
--
   drivers/pci/controller/dwc/pci-imx6.c: In function 'imx_pcie_add_lut_by_rid':
>> drivers/pci/controller/dwc/pci-imx6.c:1112:30: warning: 'sid_i' is used uninitialized [-Wuninitialized]
    1112 |         arg.map_args.args[0] = sid_i;
         |         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
   drivers/pci/controller/dwc/pci-imx6.c:1105:13: note: 'sid_i' was declared here
    1105 |         u32 sid_i, sid_m;
         |             ^~~~~
>> drivers/pci/controller/dwc/pci-imx6.c:1126:17: warning: 'sid_m' is used uninitialized [-Wuninitialized]
    1126 |         err_m = of_map_msi_id(dev->of_node, rid, &target, &sid_m);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/pci/controller/dwc/pci-imx6.c:1105:20: note: 'sid_m' was declared here
    1105 |         u32 sid_i, sid_m;
         |                    ^~~~~


vim +/dev_id +1451 include/linux/of.h

  1447	
  1448	static inline int of_map_msi_id(const struct device_node *np, u32 id,
  1449					struct device_node **target, u32 *id_out)
  1450	{
> 1451		struct of_map_id_arg arg = {
  1452			.map_args = {
  1453				.np = *target,
  1454				.args_count = 1,
  1455				.args = { *id_out },
  1456			},
  1457		};
  1458	
  1459		return of_map_id(np, id, "msi-map", "msi-map-mask", &arg);
  1460	}
  1461	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki