linux-kernel - Re: [PATCH v4 4/4] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV0eD4t5uQeAokUF@shlinux89>
Date: Tue, 6 Jan 2026 22:37:03 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Marek Vasut <marex@...ladev.com>
Cc: linux-arm-kernel@...ts.infradead.org, Fedor Ross <fedor.ross@....com>,
	Christian Eggers <ceggers@...i.de>,
	Conor Dooley <conor+dt@...nel.org>,
	Fabio Estevam <festevam@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Markus Heidelberg <m.heidelberg@....de>,
	Rob Herring <robh@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/4] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1
 and v2

Hi Marek,


Sorry for jumping in at V4.

On Tue, Dec 30, 2025 at 10:32:34PM +0100, Marek Vasut wrote:
>From: Fedor Ross <fedor.ross@....com>
>
...

>+
>+&ecspi1 {
>+	pinctrl-names = "default", "cs";
>+	pinctrl-0 = <&pinctrl_ecspi1>;
>+	pinctrl-1 = <&pinctrl_ecspi1_cs>;

Not get the point of using a separate pinctrl for "cs",
I not see driver using it, or I may miss someting.

>+	/delete-property/ dmas;
>+	/delete-property/ dma-names;

Why disable DMA here?

>+};
>+
>+&ecspi3 {
>+	pinctrl-names = "default", "cs";
>+	pinctrl-0 = <&pinctrl_ecspi3>;
>+	pinctrl-1 = <&pinctrl_ecspi3_cs>;
>+	/delete-property/ dmas;
>+	/delete-property/ dma-names;

Ditto.

>+};
>+

Regards
Peng