linux-kernel - Re: [PATCH] drm/amdgpu: fix drm panic null pointer when driver not support atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_Oh5iJirX57cJskcTyKixsLFGeDBaTgc-r15UjFt8fWVA@mail.gmail.com>
Date: Tue, 6 Jan 2026 09:47:37 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: yaolu@...inos.cn
Cc: alexander.deucher@....com, christian.koenig@....com, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: fix drm panic null pointer when driver not
 support atomic

Applied.  Thanks!

On Mon, Jan 5, 2026 at 9:37 PM <yaolu@...inos.cn> wrote:
>
> From: Lu Yao <yaolu@...inos.cn>
>
> When driver not support atomic, fb using plane->fb rather than
> plane->state->fb.
>
> Fixes: fe151ed7af54 ("drm/amdgpu: add generic display panic helper code")
> Signed-off-by: Lu Yao <yaolu@...inos.cn>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index b5d34797d606..52bc04452812 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -1880,7 +1880,12 @@ int amdgpu_display_get_scanout_buffer(struct drm_plane *plane,
>                                       struct drm_scanout_buffer *sb)
>  {
>         struct amdgpu_bo *abo;
> -       struct drm_framebuffer *fb = plane->state->fb;
> +       struct drm_framebuffer *fb;
> +
> +       if (drm_drv_uses_atomic_modeset(plane->dev))
> +               fb = plane->state->fb;
> +       else
> +               fb = plane->fb;
>
>         if (!fb)
>                 return -EINVAL;
> --
> 2.25.1
>