linux-kernel - Re: [PATCH] usb: typec: ucsi: drop an unused Kconfig symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV1ScKQ32hoOQB1G@google.com>
Date: Tue, 6 Jan 2026 18:20:32 +0000
From: Benson Leung <bleung@...gle.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Pavan Holla <pholla@...omium.org>,
	Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
	Łukasz Bartosik <ukaszb@...omium.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jameson Thies <jthies@...gle.com>,
	Andrei Kuchynski <akuchynski@...omium.org>,
	chrome-platform@...ts.linux.dev,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: drop an unused Kconfig symbol

On Sun, Dec 28, 2025 at 11:06:03AM -0800, Randy Dunlap wrote:
> EXTCON_TCSS_CROS_EC isn't used anywhere else in the kernel tree,
> so drop it from this Kconfig file.
> 
> (unless it should be EXTCON_USBC_CROS_EC ?)

I concur with abhishekpandit@...omium.org. It looks like this was a typo at
first, but removing the depends should be fine.

> 
> Fixes: f1a2241778d9 ("usb: typec: ucsi: Implement ChromeOS UCSI driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Reviewed-by: Benson Leung <bleung@...omium.org>


> ---
> Cc: Pavan Holla <pholla@...omium.org>
> Cc: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> Cc: Łukasz Bartosik <ukaszb@...omium.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jameson Thies <jthies@...gle.com>
> Cc: Andrei Kuchynski <akuchynski@...omium.org>
> Cc: chrome-platform@...ts.linux.dev
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: linux-usb@...r.kernel.org
> 
>  drivers/usb/typec/ucsi/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- linux-next-20251219.orig/drivers/usb/typec/ucsi/Kconfig
> +++ linux-next-20251219/drivers/usb/typec/ucsi/Kconfig
> @@ -73,7 +73,6 @@ config CROS_EC_UCSI
>  	tristate "UCSI Driver for ChromeOS EC"
>  	depends on MFD_CROS_EC_DEV
>  	depends on CROS_USBPD_NOTIFY
> -	depends on !EXTCON_TCSS_CROS_EC
>  	default MFD_CROS_EC_DEV
>  	help
>  	  This driver enables UCSI support for a ChromeOS EC. The EC is
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)