linux-kernel - Re: [PATCH v2 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260106173936.GA2345468-robh@kernel.org>
Date: Tue, 6 Jan 2026 11:39:36 -0600
From: Rob Herring <robh@...nel.org>
To: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Vincent Mailhol <mailhol@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Biju Das <biju.das.jz@...renesas.com>, linux-can@...r.kernel.org,
	devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: can: renesas,rcar-canfd: Specify
 reset-names

On Tue, Jan 06, 2026 at 05:17:17PM +0000, Lad, Prabhakar wrote:
> Hi Krzysztof,
> 
> Thank you for the review.
> 
> On Fri, Jan 2, 2026 at 11:16 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >
> > On Tue, Dec 30, 2025 at 11:58:11AM +0000, Prabhakar wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > >
> > > Specify the expected reset-names for the Renesas CAN-FD controller on
> > > RZ/G2L and RZ/G3E SoCs.
> >
> > You should explain here from where you got the actual names.
> >
> > Otherwise you got following review:
> >
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > > ---
> > > v1->v2:
> > > - Moved reset-names to top-level properties.
> > > ---
> > >  .../bindings/net/can/renesas,rcar-canfd.yaml  | 33 +++++++++++--------
> > >  1 file changed, 19 insertions(+), 14 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > > index e129bdceef84..9bfd4f44e4d4 100644
> > > --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > > @@ -122,6 +122,11 @@ properties:
> > >
> > >    resets: true
> > >
> > > +  reset-names:
> > > +    items:
> > > +      - const: rstp_n
> > > +      - const: rstc_n
> >
> > rst seems redundant. _n as well. Are these names from datasheet? How are
> > they called in this device (not the soc) datasheet exactly? Because it
> > feels you use pin or SoC names which is not useful.
> >
> rstp_n/rstc_n are coming from the SoC HW manual and is already used by
> the driver (since commit 76e9353a80e9 "can: rcar_canfd: Add support
> for RZ/G2L family"). The reset-names existed previously but were
> dropped as of commit 466c8ef7b66b "dt-bindings: can:
> renesas,rcar-canfd: Simplify the conditional schema". Let me know if
> you want me to rename them but the driver will have to maintain the
> backward compatibility or do you want me to drop this patch.

The names are fine. The above is useful information that should be in 
the commit msg. Please help us if we've already reviewed something.

Rob