linux-kernel - Re: [PATCH] tools/testing/selftests: fix gup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41467ff9-46f3-4937-ae96-3bde178a63af@kernel.org>
Date: Tue, 6 Jan 2026 19:40:07 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Mark Brown <broonie@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
 John Hubbard <jhubbard@...dia.com>, Peter Xu <peterx@...hat.com>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>,
 Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/testing/selftests: fix gup_longterm for unknown fs

On 1/6/26 16:45, Lorenzo Stoakes wrote:
> Commit 66bce7afbaca ("selftests/mm: fix test result reporting in
> gup_longterm") introduced a small bug causing unknown filesystems to always
> result in a test failure.
> 
> This is because do_test() was updated to use a common reporting path, but
> this case appears to have been missed.
> 
> This is problematic for e.g. virtme-ng which uses an overlayfs file system,
> causing gup_longterm to appear to fail each time due to a test count
> mismatch:
> 
> 	# Planned tests != run tests (50 != 46)
> 	# Totals: pass:24 fail:0 xfail:0 xpass:0 skip:22 error:0
> 
> The fix is to simply change the return into a break.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> Fixes: 66bce7afbaca ("selftests/mm: fix test result reporting in gup_longterm")
> ---

Reviewed-by: David Hildenbrand (Red Hat) <david@...nel.org>

-- 
Cheers

David