linux-kernel - Re: [PATCH 04/11] fat: cleanup the flags for fat_truncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qeask1x.fsf@mail.parknet.co.jp>
Date: Wed, 07 Jan 2026 02:55:06 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Christoph Hellwig <hch@....de>
Cc: Christian Brauner <brauner@...nel.org>, Al Viro
 <viro@...iv.linux.org.uk>,
        David Sterba <dsterba@...e.com>, Jan Kara
 <jack@...e.cz>,
        Mike Marshall <hubcap@...ibond.com>,
        Martin Brandenburg
 <martin@...ibond.com>,
        Carlos Maiolino <cem@...nel.org>, Stefan Roesch
 <shr@...com>,
        Jeff Layton <jlayton@...nel.org>,
        Trond Myklebust
 <trondmy@...nel.org>,
        Anna Schumaker <anna@...nel.org>, linux-kernel@...r.kernel.org,
        linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        gfs2@...ts.linux.dev, io-uring@...r.kernel.org,
        devel@...ts.orangefs.org, linux-unionfs@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-xfs@...r.kernel.org,
        linux-nfs@...r.kernel.org
Subject: Re: [PATCH 04/11] fat: cleanup the flags for fat_truncate_time

OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> writes:

> Christoph Hellwig <hch@....de> writes:
>
>> Fat only has a single on-disk timestamp covering ctime and mtime.  Add
>> fat-specific flags that indicate which timestamp fat_truncate_time should
>> update to make this more clear.  This allows removing no-op
>> fat_truncate_time calls with the S_CTIME flag and prepares for removing
>> the S_* flags.
>>
>> Signed-off-by: Christoph Hellwig <hch@....de>
>
> This breaks fat_update_time() by calling fat_truncate_time() with old
> S_* flags (later patch looks like fixing though). Please add the commit
> comment about it, or fix it in this patch.
>
> Thanks.

Ah, I was overlooking that new value is using same value with S_*.
So

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>