linux-kernel - Re: [PATCH v2] PCI/IDE: Fix duplicate stream symlink names for TSM class devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVxsdZlrh87tWuFk@yilunxu-OptiPlex-7050>
Date: Tue, 6 Jan 2026 09:59:17 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: linux-coco@...ts.linux.dev, linux-pci@...r.kernel.org,
	dan.j.williams@...el.com, yilun.xu@...el.com,
	baolu.lu@...ux.intel.com, zhenzhong.duan@...el.com,
	linux-kernel@...r.kernel.org, yi1.lai@...el.com, helgaas@...nel.org
Subject: Re: [PATCH v2] PCI/IDE: Fix duplicate stream symlink names for TSM
 class devices

On Mon, Jan 05, 2026 at 10:13:17AM +0000, Jonathan Cameron wrote:
> On Mon,  5 Jan 2026 17:35:16 +0800
> Xu Yilun <yilun.xu@...ux.intel.com> wrote:
> 
> > The name streamH.R.E is used for 2 symlinks:
> > 
> >   1. TSM class devices: /sys/class/tsm/tsmN/streamH.R.E
> >   2. host bridge devices: /sys/devices/pciDDDD:BB/streamH.R.E
> 
> For those who have managed to completely forget, it would be useful
> to just mention what H R and E are. Given the docs
> say H is the host bridge number I'm a little confused why it
> isn't unique. At least at first glance I'd expect to see

No, the Documentation/ABI/testing/sysfs-devices-pci-host-bridge says
H represents a Stream ID slot (or a Stream index) within the host
bridge's context, not the host bridge index itself. So do R/E.

> stream0.0.0 and stream 1.0.0 your example.
> Maybe H isn't unique across segments / PCI Domains? (DDDD in the above)
> Maybe it should be?

No. The counter of H along with the pciDDDD:BB/available_secure_streams,
indicate the platform hardware limitation on the maximum number of
Streams a host bridge can support. It should not be a global counter
across System.

Thanks,
Yilun