linux-kernel - Re: [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <355c3ae0-9603-4750-b83d-64447b6581ce@kernel.org>
Date: Tue, 6 Jan 2026 20:20:51 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vijay Kumar Tumati <vijay.tumati@....qualcomm.com>,
 Hangxiang Ma <hangxiang.ma@....qualcomm.com>
Cc: Loic Poulain <loic.poulain@....qualcomm.com>,
 Robert Foss <rfoss@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, linux-i2c@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 jeyaprakash.soundrapandian@....qualcomm.com
Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss

On 06/01/2026 20:18, Krzysztof Kozlowski wrote:
> On 06/01/2026 19:40, Vijay Kumar Tumati wrote:
>>
>> On 11/27/2025 12:12 AM, Krzysztof Kozlowski wrote:
>>> On Wed, Nov 26, 2025 at 01:38:40AM -0800, Hangxiang Ma wrote:

Look here^

>>>> +		};
>>>> +
>>>> +		cci0: cci@...b000 {
>>> Looks completely mis-ordered/sorted. What are the nodes above and below?
>> Hi Krzysztof, sorry, not sure how you mean exactly. The ones above are 
>> the pinctrl nodes. Each CCI has two masters using two GPIOs each, one 
> 
> Why would pinctrl nodes matter anyhow? Please read how DTS syntax works.
> 
>> for clk and one for data. The ones below are the actual CCI HW nodes 
>> that make use of the pinctrls. I believe this is inline with previous 
>> generations. Have I missed something? Thanks.
> I wrote what is wrong. Is this maintaining proper sorting? Did you read
> DTS coding style?
> 


Heh, you received my review 1 day after your posting.

You replied to my review 5-6 weeks after, yet you still expect me to
understand the context and provide clarifications.

There is simpler way: NAK.

You will not get your patches merged with such latency and such replies
not even trying to address the problem or learn about it.

Best regards,
Krzysztof