linux-kernel - Re: [PATCH v2 net-next 03/10] dt-bindings: phy-common-props: ensure protocol-names are unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176772377743.2503618.2171230504388641306.robh@kernel.org>
Date: Tue, 6 Jan 2026 12:22:58 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: Conor Dooley <conor+dt@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
	linux-phy@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, Eric Woudstra <ericwouds@...il.com>,
	devicetree@...r.kernel.org,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Lee Jones <lee@...nel.org>, Vinod Koul <vkoul@...nel.org>,
	Daniel Golle <daniel@...rotopia.org>,
	Jakub Kicinski <kuba@...nel.org>,
	Bjørn Mork <bjorn@...k.no>,
	linux-arm-kernel@...ts.infradead.org,
	Patrice Chotard <patrice.chotard@...s.st.com>,
	Marek Behún <kabel@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Paolo Abeni <pabeni@...hat.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v2 net-next 03/10] dt-bindings: phy-common-props: ensure
 protocol-names are unique


On Sat, 03 Jan 2026 23:03:56 +0200, Vladimir Oltean wrote:
> Rob Herring points out that "The default for .*-names is the entries
> don't have to be unique.":
> https://lore.kernel.org/linux-phy/20251204155219.GA1533839-robh@kernel.org/
> 
> Let's use uniqueItems: true to make sure the schema enforces this. It
> doesn't make sense in this case to have duplicate properties for the
> same SerDes protocol.
> 
> Note that this can only be done with the $defs + $ref pattern as
> established by the previous commit. When the tx-p2p-microvolt-names
> constraints were expressed directly under "properties", it would have
> been validated by the string-array meta-schema, which does not support
> the 'uniqueItems' keyword as can be seen below.
> 
> properties:tx-p2p-microvolt-names: Additional properties are not allowed ('uniqueItems' was unexpected)
>         from schema $id: http://devicetree.org/meta-schemas/string-array.yaml
> 
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> v1->v2: patch is new
> 
>  Documentation/devicetree/bindings/phy/phy-common-props.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>