[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aV2A39fXgzuM4Toa@google.com>
Date: Tue, 6 Jan 2026 13:38:39 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Ackerley Tng <ackerleytng@...gle.com>
Cc: Vishal Annapurve <vannapurve@...gle.com>, Yan Zhao <yan.y.zhao@...el.com>, pbonzini@...hat.com,
linux-kernel@...r.kernel.org, kvm@...r.kernel.org, x86@...nel.org,
rick.p.edgecombe@...el.com, dave.hansen@...el.com, kas@...nel.org,
tabba@...gle.com, michael.roth@....com, david@...nel.org, sagis@...gle.com,
vbabka@...e.cz, thomas.lendacky@....com, nik.borisov@...e.com,
pgonda@...gle.com, fan.du@...el.com, jun.miao@...el.com,
francescolavra.fl@...il.com, jgross@...e.com, ira.weiny@...el.com,
isaku.yamahata@...el.com, xiaoyao.li@...el.com, kai.huang@...el.com,
binbin.wu@...ux.intel.com, chao.p.peng@...el.com, chao.gao@...el.com
Subject: Re: [PATCH v3 00/24] KVM: TDX huge page support for private memory
On Tue, Jan 06, 2026, Ackerley Tng wrote:
> Vishal Annapurve <vannapurve@...gle.com> writes:
>
> > On Tue, Jan 6, 2026 at 2:19 AM Yan Zhao <yan.y.zhao@...el.com> wrote:
> >>
> >> - EPT mapping size and folio size
> >>
> >> This series is built upon the rule in KVM that the mapping size in the
> >> KVM-managed secondary MMU is no larger than the backend folio size.
> >>
>
> I'm not familiar with this rule and would like to find out more. Why is
> this rule imposed?
Because it's the only sane way to safely map memory into the guest? :-D
> Is this rule there just because traditionally folio sizes also define the
> limit of contiguity, and so the mapping size must not be greater than folio
> size in case the block of memory represented by the folio is not contiguous?
Pre-guest_memfd, KVM didn't care about folios. KVM's mapping size was (and still
is) strictly bound by the host mapping size. That's handles contiguous addresses,
but it _also_ handles contiguous protections (e.g. RWX) and other attributes.
> In guest_memfd's case, even if the folio is split (just for refcount
> tracking purposese on private to shared conversion), the memory is still
> contiguous up to the original folio's size. Will the contiguity address
> the concerns?
Not really? Why would the folio be split if the memory _and its attributes_ are
fully contiguous? If the attributes are mixed, KVM must not create a mapping
spanning mixed ranges, i.e. with multiple folios.
Powered by blists - more mailing lists