linux-kernel - Re: [PATCH bpf-next v4 1/6] crypto: Add BPF hash algorithm type registration module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a780c0a-a710-43d3-8d73-7bbb19090b30@linux.dev>
Date: Tue, 6 Jan 2026 21:57:05 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Daniel Hodges <git@...ielhodges.dev>, bpf@...r.kernel.org
Cc: Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Song Liu <song@...nel.org>,
 Mykyta Yatsenko <yatsenko@...a.com>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Yonghong Song
 <yonghong.song@...ux.dev>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S . Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf-next v4 1/6] crypto: Add BPF hash algorithm type
 registration module

On 05/01/2026 17:37, Daniel Hodges wrote:
> Add bpf_crypto_shash module that registers a hash type with the BPF
> crypto infrastructure, enabling BPF programs to access kernel hash
> algorithms through a unified interface.
> 
> Update the bpf_crypto_type interface with hash-specific callbacks:
>     - alloc_tfm: Allocates crypto_shash context with proper descriptor size
>     - free_tfm: Releases hash transform and context memory
>     - has_algo: Checks algorithm availability via crypto_has_shash()
>     - hash: Performs single-shot hashing via crypto_shash_digest()
>     - digestsize: Returns the output size for the hash algorithm
>     - get_flags: Exposes transform flags to BPF programs
> 
> Update bpf_shash_ctx to contain crypto_shash transform and shash_desc
> descriptor to accommodate algorithm-specific descriptor requirements.
> 
> Signed-off-by: Daniel Hodges <git@...ielhodges.dev>
> ---
>   MAINTAINERS               |  1 +
>   crypto/Makefile           |  3 ++
>   crypto/bpf_crypto_shash.c | 95 +++++++++++++++++++++++++++++++++++++++
>   3 files changed, 99 insertions(+)
>   create mode 100644 crypto/bpf_crypto_shash.c

[...]

> +static const struct bpf_crypto_type bpf_crypto_shash_type = {
> +	.alloc_tfm	= bpf_crypto_shash_alloc_tfm,
> +	.free_tfm	= bpf_crypto_shash_free_tfm,
> +	.has_algo	= bpf_crypto_shash_has_algo,
> +	.hash		= bpf_crypto_shash_hash,

I don't see a definition of hash() callback in struct bpf_crypto_type

> +	.digestsize	= bpf_crypto_shash_digestsize,
> +	.get_flags	= bpf_crypto_shash_get_flags,
> +	.owner		= THIS_MODULE,
> +	.name		= "hash",
> +};