linux-kernel - Re: [PATCH] PCI/P2PDMA: Add missing struct p2pdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260106221852.GA381083@bhelgaas>
Date: Tue, 6 Jan 2026 16:18:52 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
	Logan Gunthorpe <logang@...tatee.com>,
	Jason Gunthorpe <jgg@...pe.ca>, Alex Williamson <alex@...zbot.org>,
	Ankit Agrawal <ankita@...dia.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI/P2PDMA: Add missing struct p2pdma_provider
 documentation

On Sun, Jan 04, 2026 at 02:51:28PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> Two fields in struct p2pdma_provider were not documented, which resulted
> in the following kernel-doc warning:
> 
>   Warning: include/linux/pci-p2pdma.h:26 struct member 'owner' not described in 'p2pdma_provider'
>   Warning: include/linux/pci-p2pdma.h:26 struct member 'bus_offset' not described in 'p2pdma_provider'
> 
> Repro:
> 
>   $ scripts/kernel-doc -none include/linux/pci-p2pdma.h
> 
> Fixes: f58ef9d1d135 ("PCI/P2PDMA: Separate the mmap() support from the core logic")
> Reported-by: Bjorn Helgaas <helgaas@...nel.org>
> Closes: https://lore.kernel.org/all/20260102234033.GA246107@bhelgaas
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>

Applied to pci/misc for v6.20, thanks!

Alex, let me know if you'd rather take this (you merged f58ef9d1d135).

> ---
>  include/linux/pci-p2pdma.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/pci-p2pdma.h b/include/linux/pci-p2pdma.h
> index 517e121d2598..873de20a2247 100644
> --- a/include/linux/pci-p2pdma.h
> +++ b/include/linux/pci-p2pdma.h
> @@ -20,6 +20,8 @@ struct scatterlist;
>   * struct p2pdma_provider
>   *
>   * A p2pdma provider is a range of MMIO address space available to the CPU.
> + * @owner: Device to which this provider belongs.
> + * @bus_offset: Bus offset for p2p communication.
>   */
>  struct p2pdma_provider {
>  	struct device *owner;
> 
> ---
> base-commit: f8f9c1f4d0c7a64600e2ca312dec824a0bc2f1da
> change-id: 20260104-fix-p2p-kdoc-3f503e6d6a55
> 
> Best regards,
> --  
> Leon Romanovsky <leonro@...dia.com>
>