linux-kernel - Re: [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13e4593c-c061-40cb-a0e8-78764488ca67@redhat.com>
Date: Tue, 6 Jan 2026 17:44:15 -0500
From: Matthew Sakai <msakai@...hat.com>
To: Julia Lawall <Julia.Lawall@...ia.fr>
Cc: yunbolyu@....edu.sg, kexinsun@...il.nju.edu.cn, ratnadiraw@....edu.sg,
 xutong.ma@...ia.fr, dm-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name
 reference

On 12/30/25 10:22 AM, Julia Lawall wrote:
> There is no function advance_compression_stage().  But
> advance_data_vio_compression_stage() does iterate through
> the values of the data_vio_compression_stage enum, so it
> seems to be what was intended.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

We must have missed this comment when we were renaming functions a few 
years ago.

Reviewed-by: Matthew Sakai <msakai@...hat.com>

> ---
>   drivers/md/dm-vdo/data-vio.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-vdo/data-vio.h b/drivers/md/dm-vdo/data-vio.h
> index 067b983bb291..58a1ac806885 100644
> --- a/drivers/md/dm-vdo/data-vio.h
> +++ b/drivers/md/dm-vdo/data-vio.h
> @@ -88,8 +88,8 @@ struct zoned_pbn {
>   };
>   
>   /*
> - * Where a data_vio is on the compression path; advance_compression_stage() depends on the order of
> - * this enum.
> + * Where a data_vio is on the compression path; advance_data_vio_compression_stage()
> + * depends on the order of this enum.
>    */
>   enum data_vio_compression_stage {
>   	/* A data_vio which has not yet entered the compression path */
>