linux-kernel - Re: [PATCH v1] ACPI: bus: Fix typo under sizeof() in acpi_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4bcbf926-4543-4992-9803-6ad281bf42f4@kernel.org>
Date: Tue, 6 Jan 2026 16:44:43 -0600
From: "Mario Limonciello (AMD) (kernel.org)" <superm1@...nel.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
 Linux ACPI <linux-acpi@...r.kernel.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
 Jonathan Cameron <jonathan.cameron@...wei.com>,
 LKML <linux-kernel@...r.kernel.org>,
 Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
 Hans de Goede <hansg@...nel.org>
Subject: Re: [PATCH v1] ACPI: bus: Fix typo under sizeof() in acpi_run_osc()

On 12/29/2025 7:27 AM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Subject:
> 
> The sizeof(32) in acpi_run_osc() should be sizeof(u32), so fix it.
> 
> Fixes: e5322888e6bf ("ACPI: bus: Rework the handling of \_SB._OSC platform features")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@...nel.org>
> ---
> 
> Commit e5322888e6bf is a linux-next one.
> 
> ---
>   drivers/acpi/bus.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -294,7 +294,7 @@ acpi_status acpi_run_osc(acpi_handle han
>   	int ret;
>   
>   	if (!context || !context->cap.pointer ||
> -	    context->cap.length < 2 * sizeof(32) ||
> +	    context->cap.length < 2 * sizeof(u32) ||
>   	    guid_parse(context->uuid_str, &guid))
>   		return AE_BAD_PARAMETER;
>   
> 
> 
>