linux-kernel - Re: [PATCH] perf parse-events: Fix evsel allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aV2SnF7yV8QUoeeF@google.com>
Date: Tue, 6 Jan 2026 14:54:20 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Faisal Bukhari <faisalbukhari523@...il.com>,
	Ian Rogers <irogers@...gle.com>,
	James Clark <james.clark@...aro.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>, thomas.falcon@...el.com,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf parse-events: Fix evsel allocation failure

On Tue, Jan 06, 2026 at 06:55:57PM -0300, Arnaldo Carvalho de Melo wrote:
> On Mon, Sep 22, 2025 at 11:38:34PM +0530, Faisal Bukhari wrote:
> > If evsel__new_idx() returns NULL, the function currently jumps 
> > to label 'out_err'.
> > Here, references to `cpus` and `pmu_cpus` are dropped.
> > Also, resources held by evsel->name and evsel->metric_id are freed.
> > But if evsel__new_idx() returns NULL, 
> > it can lead to NULL pointer dereference.
> 
> You forgot to add:
> 
> Fixes: cd63c22168257a0b ("perf parse-events: Minor __add_event refactoring")
> 
> Reviewed-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> Namhyung, I think this should go into v6.19-rc,

Sure, will add.

Thanks,
Namhyung