linux-kernel - Re: [PATCH] platform/x86: ISST: Check for admin capability for write commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8330384fc70c6ffdd7d1bd8626e322adf1e19080.camel@linux.intel.com>
Date: Tue, 06 Jan 2026 15:07:32 -0800
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Hans de Goede <hansg@...nel.org>, platform-driver-x86@...r.kernel.org,
 LKML	 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: ISST: Check for admin capability for
 write commands

On Tue, 2026-01-06 at 11:49 +0200, Ilpo Järvinen wrote:
> On Mon, 29 Dec 2025, Srinivas Pandruvada wrote:
> 
> > In some SST deployments, administrators want to allow reading SST
> > capabilities for non-root users. This can be achieved by changing
> > file
> > permissions for "/dev/isst_interface", but they still want to
> > prevent
> > any changes to the SST configuration by non-root users.
> > 
> > This capability was available before for non-TPMI SST. Extend the
> > same
> > capability for TPMI SST by adding a check for CAP_SYS_ADMIN for all
> > write commands.
> > 
> > Signed-off-by: Srinivas Pandruvada
> > <srinivas.pandruvada@...ux.intel.com>
> > ---
> >  .../x86/intel/speed_select_if/isst_tpmi_core.c        | 11 ++++++-
> > ----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git
> > a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> > b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> > index 47026bb3e1af..a624e0b2991f 100644
> > --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> > +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> > @@ -612,7 +612,7 @@ static long isst_if_core_power_state(void
> > __user *argp)
> >  		return -EINVAL;
> >  
> >  	if (core_power.get_set) {
> > -		if (power_domain_info->write_blocked)
> > +		if (power_domain_info->write_blocked ||
> > !capable(CAP_SYS_ADMIN))
> 
> Hi,
> 
> This check doesn't exist in my tree, you seem to have mis-submitted
> this 
> independently of the other series that adds the check.

Hi llpo,

This was part of the series, which was submitted as bug fix before.
[PATCH 0/2] platform/x86: ISST: Fix for write lock and suspend/resume

I should have added this as dependency.

Thanks,
Srinivas