linux-kernel - Re: [PATCH v2] uvcvideo: simplify spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260106035159.GA11450@pendragon.ideasonboard.com>
Date: Tue, 6 Jan 2026 05:51:59 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Chen Changcheng <chenchangcheng@...inos.cn>
Cc: krzk@...nel.org, hansg@...nel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, mchehab@...nel.org
Subject: Re: [PATCH v2] uvcvideo: simplify spin_lock using guards

On Mon, Jan 05, 2026 at 05:35:12PM +0800, Chen Changcheng wrote:
> > This is an undesired syntax explicitly documented as one to avoid. You
> > need here proper assignment, not NULL. Please don't use cleanup.h if you
> > do not intend to follow it because it does not make the code simpler.
> 
> Thank you for your correction and feedback. I made the change initially
> because I saw similar patterns using "__free(...) = NULL" in patches from
> other driver modules, which led me to overlook the core paradigm of
> cleanup.h that requires a "declaration with a meaningful initializer."

Do you plan to send a v3 ?

-- 
Regards,

Laurent Pinchart