[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2a9f7c54-3669-4f8b-b46b-b7e01712a1b8@linaro.org>
Date: Tue, 6 Jan 2026 09:21:09 +0100
From: neil.armstrong@...aro.org
To: Avinal Kumar <avinal.xlvii@...il.com>, jessica.zhang@....qualcomm.com,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi
wrapped functions
Hi,
On 11/27/25 17:08, Avinal Kumar wrote:
> Changes the panasonic-vvx10f034n00 panel to multi
> style functions for improved error handling.
>
> Signed-off-by: Avinal Kumar <avinal.xlvii@...il.com>
> ---
> Here is the todo list for reference: https://www.kernel.org/doc/html/latest/gpu/todo.html#transition-away-from-using-deprecated-mipi-dsi-functions
>
> This is my first patch in Linux Kernel :)
>
> drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> index 3c3308fc55df..03c87c02fb57 100644
> --- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> +++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> @@ -44,7 +44,12 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel)
>
> static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt)
> {
> - return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi);
> + struct mipi_dsi_multi_context dsi_ctx = {
> + .dsi = wuxga_nt->dsi
> + };
> +
> + mipi_dsi_turn_on_peripheral_multi(&dsi_ctx);
> + return dsi_ctx.accum_err;
> }
>
> static int wuxga_nt_panel_disable(struct drm_panel *panel)
Why didn't you also update wuxga_nt_panel_disable() ?
Thanks,
Neil
Powered by blists - more mailing lists