linux-kernel - Re: [PATCH 2/2] drm/panic: Fix expected string for QR_CODE in drm_panic_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb73c2c6-be68-42bc-96e1-f6595f9dd0ed@igalia.com>
Date: Tue, 6 Jan 2026 08:19:20 +0000
From: Tvrtko Ursulin <tvrtko.ursulin@...lia.com>
To: Nathan Chancellor <nathan@...nel.org>,
 Jocelyn Falempe <jfalempe@...hat.com>,
 Javier Martinez Canillas <javierm@...hat.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/panic: Fix expected string for QR_CODE in
 drm_panic_type_map


On 06/01/2026 06:19, Nathan Chancellor wrote:
> The help text of CONFIG_DRM_PANIC_SCREEN_QR_CODE documents the expected
> value to CONFIG_DRM_PANIC_SCREEN as "qr_code" but drm_panic_type_map
> checks for "qr". Adjust drm_panic_type_map and the module description to
> match so that existing configurations do not stop working.
> 
> Fixes: e85e9ccf3f84 ("drm/panic: Report invalid or unsupported panic modes")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> ---
>   drivers/gpu/drm/drm_panic.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c
> index 0cd574dd9d88..d6d3b8d85dea 100644
> --- a/drivers/gpu/drm/drm_panic.c
> +++ b/drivers/gpu/drm/drm_panic.c
> @@ -823,7 +823,7 @@ static const char *drm_panic_type_map[] = {
>   	[DRM_PANIC_TYPE_KMSG] = "kmsg",
>   	[DRM_PANIC_TYPE_USER] = "user",
>   #if IS_ENABLED(CONFIG_DRM_PANIC_SCREEN_QR_CODE)
> -	[DRM_PANIC_TYPE_QR] = "qr",
> +	[DRM_PANIC_TYPE_QR] = "qr_code",
>   #endif
>   };
>   
> @@ -855,7 +855,7 @@ static const struct kernel_param_ops drm_panic_ops = {
>   module_param_cb(panic_screen, &drm_panic_ops, NULL, 0644);
>   MODULE_PARM_DESC(panic_screen,
>   #if IS_ENABLED(CONFIG_DRM_PANIC_SCREEN_QR_CODE)
> -		 "Choose what will be displayed by drm_panic, 'user', 'kmsg' or 'qr' [default="
> +		 "Choose what will be displayed by drm_panic, 'user', 'kmsg' or 'qr_code' [default="
>   #else
>   		 "Choose what will be displayed by drm_panic, 'user' or 'kmsg' [default="
>   #endif
> 

Looks like I mistyped when refactoring. Should have used copy and paste, 
sorry about that.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@...lia.com>

Regards,

Tvrtko