linux-kernel - Re: [PATCH] drm/panel: himax-hx83102: change to gpiod_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bcc749c-84ba-4f1d-a383-51f58e8a5422@linaro.org>
Date: Tue, 6 Jan 2026 09:17:01 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Vladimir Yakovlev <vovchkir@...il.com>,
 Cong Yang <yangcong5@...qin.corp-partner.google.com>
Cc: Jessica Zhang <jesszhan0024@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: himax-hx83102: change to
 gpiod_set_value_cansleep

On 12/8/25 17:16, Vladimir Yakovlev wrote:
> It's better to use gpiod_set_value_cansleep because the panel can be
> connected via i2c/spi expander or similar external devices
> 
> for reference see Documentation/driver-api/gpio/consumer.rst
> 
> Signed-off-by: Vladimir Yakovlev <vovchkir@...il.com>
> ---
>   drivers/gpu/drm/panel/panel-himax-hx83102.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-himax-hx83102.c b/drivers/gpu/drm/panel/panel-himax-hx83102.c
> index 602f1adfc8ee..f31e502f71a3 100644
> --- a/drivers/gpu/drm/panel/panel-himax-hx83102.c
> +++ b/drivers/gpu/drm/panel/panel-himax-hx83102.c
> @@ -1049,7 +1049,7 @@ static int hx83102_unprepare(struct drm_panel *panel)
>   {
>   	struct hx83102 *ctx = panel_to_hx83102(panel);
>   
> -	gpiod_set_value(ctx->enable_gpio, 0);
> +	gpiod_set_value_cansleep(ctx->enable_gpio, 0);
>   	usleep_range(1000, 2000);
>   	regulator_disable(ctx->avee);
>   	regulator_disable(ctx->avdd);
> @@ -1065,7 +1065,7 @@ static int hx83102_prepare(struct drm_panel *panel)
>   	struct mipi_dsi_device *dsi = ctx->dsi;
>   	struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
>   
> -	gpiod_set_value(ctx->enable_gpio, 0);
> +	gpiod_set_value_cansleep(ctx->enable_gpio, 0);
>   	usleep_range(1000, 1500);
>   
>   	dsi_ctx.accum_err = regulator_enable(ctx->pp1800);
> @@ -1089,11 +1089,11 @@ static int hx83102_prepare(struct drm_panel *panel)
>   
>   	usleep_range(1000, 2000);
>   
> -	gpiod_set_value(ctx->enable_gpio, 1);
> +	gpiod_set_value_cansleep(ctx->enable_gpio, 1);
>   	usleep_range(1000, 2000);
> -	gpiod_set_value(ctx->enable_gpio, 0);
> +	gpiod_set_value_cansleep(ctx->enable_gpio, 0);
>   	usleep_range(1000, 2000);
> -	gpiod_set_value(ctx->enable_gpio, 1);
> +	gpiod_set_value_cansleep(ctx->enable_gpio, 1);
>   	usleep_range(6000, 10000);
>   
>   	dsi_ctx.accum_err = ctx->desc->init(ctx);
> @@ -1107,7 +1107,7 @@ static int hx83102_prepare(struct drm_panel *panel)
>   	return 0;
>   
>   poweroff:
> -	gpiod_set_value(ctx->enable_gpio, 0);
> +	gpiod_set_value_cansleep(ctx->enable_gpio, 0);
>   	regulator_disable(ctx->avee);
>   poweroffavdd:
>   	regulator_disable(ctx->avdd);

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>

Thanks,
Neil