linux-kernel - Re: [PATCH v2] platform/x86/amd: Fix memory leak in wbrf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260106091104.745278-1-zilin@seu.edu.cn>
Date: Tue,  6 Jan 2026 09:11:04 +0000
From: Zilin Guan <zilin@....edu.cn>
To: ilpo.jarvinen@...ux.intel.com
Cc: Markus.Elfring@....de,
	hansg@...nel.org,
	jianhao.xu@....edu.cn,
	linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	zilin@....edu.cn
Subject: Re: [PATCH v2] platform/x86/amd: Fix memory leak in wbrf_record()

On Mon, Jan 05, 2026 at 03:52:14PM +0200, "Ilpo Järvinen" wrote:
> While I'm certainly not against in converting also 'obj', this patch 
> should be split to two, where the first patch fixes the case that is 
> current lacking kfree(), and the second that does convert 'obj'. IIRC, on 
> can just use kfree() directly for releasing it so adding the new 
> DEFINE_FREE() doesn't seem necessary.

Hi Ilpo,

Thanks for your review.

I will follow your suggestion to split the patch into two in v3.

Just for context, the reason I modified 'obj' in v2 is to avoid mixing 
goto-based cleanup with scope-based cleanup, as recommended in 
cleanup.h [1]. This was also why I stuck to goto in v1 
(to avoid touching 'obj'). 

[1] https://elixir.bootlin.com/linux/v6.19-rc4/source/include/linux/cleanup.h#L148-L153

Best regards,
Zilin Guan