linux-kernel - Re: [PATCH net-next v2 5/5] net: phy: realtek: get rid of magic number in rtlgen_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4564a756-ec4e-4038-8a84-35410e9c6779@bootlin.com>
Date: Tue, 6 Jan 2026 10:42:29 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Daniel Golle <daniel@...rotopia.org>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean <vladimir.oltean@....com>,
 Michael Klein <michael@...sekall.de>, Aleksander Jan Bajkowski
 <olek2@...pl>, Bevan Weiss <bevan.weiss@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/5] net: phy: realtek: get rid of magic
 number in rtlgen_read_status()

On 05/01/2026 17:39, Daniel Golle wrote:
> Use newly introduced helper macros RTL822X_VND2_TO_PAGE and
> RTL822X_VND2_TO_PAGE_REG to access RTL_VEND2_PHYSR register over Clause-22
> paged access instead of using magic numbers.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>

That's nicer indeed !

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime