linux-kernel - Re: [PATCH V3 4/4] media: i2c: ds90ub960: Add support for DS90UB954-Q1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176769924521.1604677.11258559573163518409@freya>
Date: Tue, 06 Jan 2026 17:04:05 +0530
From: Jai Luthra <jai.luthra@...asonboard.com>
To: Yemike Abhilash Chandra <y-abhilashchandra@...com>, conor+dt@...nel.org, hverkuil@...all.nl, krzk+dt@...nel.org, laurent.pinchart@...asonboard.com, mchehab@...nel.org, robh@...nel.org, sakari.ailus@...ux.intel.com, tomi.valkeinen@...asonboard.com
Cc: hansg@...nel.org, mehdi.djait@...ux.intel.com, ribalda@...omium.org, git@...tzsch.eu, vladimir.zapolskiy@...aro.org, benjamin.mugnier@...s.st.com, dongcheng.yan@...el.com, u-kumar1@...com, jai.luthra@...ux.dev, linux-media@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, y-abhilashchandra@...com
Subject: Re: [PATCH V3 4/4] media: i2c: ds90ub960: Add support for DS90UB954-Q1

Hi Abhilash,

Quoting Yemike Abhilash Chandra (2025-12-19 17:59:55)
> DS90UB954-Q1 is an FPDLink-III deserializer that is mostly register
> compatible with DS90UB960-Q1. The main difference is that it supports half
> of the RX and TX ports, i.e. 2x FPDLink RX ports and 1x CSI TX port.
> 
> A couple of differences are between the status registers and the
> strobe setting registers. Hence accommodate these differences in
> the UB960 driver so that we can reuse a large part of the existing code.
> 
> Link: https://www.ti.com/lit/gpn/ds90ub954-q1
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@...com>
> ---
> Changelog:
> Changes in v3:
> - Remove redundant reads and writes to the same register. (Tomi)
> - Correct the bit positions for data delay in set_strobe_pos for UB954. (Tomi)
> - Address a few minor nitpicks in code comments. (Tomi)
> 
>  drivers/media/i2c/Kconfig     |   4 +-
>  drivers/media/i2c/ds90ub960.c | 182 ++++++++++++++++++++++++----------
>  2 files changed, 129 insertions(+), 57 deletions(-)
> 

Reviewed-by: Jai Luthra <jai.luthra@...asonboard.com>

[...]