linux-kernel - Re: [PATCH] lib/glob: convert selftest to KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXnAtySPPgLGKEv7k9TGR9XuRc6hFzQgdyv-xUSA+oYZQ@mail.gmail.com>
Date: Tue, 6 Jan 2026 12:35:15 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Kir Chou <note351@...mail.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, 
	davidgow@...gle.com, brendan.higgins@...ux.dev, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	kirchou@...gle.com
Subject: Re: [PATCH] lib/glob: convert selftest to KUnit

Hi Kir,

On Mon, 5 Jan 2026 at 04:53, Kir Chou <note351@...mail.com> wrote:
> This patch converts the existing glob selftest (lib/globtest.c) to use
> the KUnit framework (lib/glob_kunit.c).
>
> The new test:
>
> - Migrates all 64 test cases from the original test to the KUnit suite.
> - Removes the custom 'verbose' module parameter as KUnit handles logging.
> - Updates Kconfig.debug and Makefile to support the new KUnit test.
> - Updates Kconfig and Makefile to remove the original selftest.
> - Updates GLOB_SELFTEST to GLOB_KUNIT_TEST for arch/m68k/configs.
>
> This commit is verified by `./tools/testing/kunit/kunit.py run`
> with the .kunit/.kunitconfig:
>
> ```
> CONFIG_KUNIT=y
> CONFIG_GLOB_KUNIT_TEST=y
> ```
>
> Signed-off-by: Kir Chou <note351@...mail.com>

Thanks for your patch!

> --- a/arch/m68k/configs/amiga_defconfig
> +++ b/arch/m68k/configs/amiga_defconfig
> @@ -600,7 +600,7 @@ CONFIG_CRYPTO_USER_API_AEAD=m
>  CONFIG_PRIME_NUMBERS=m
>  CONFIG_CRC_BENCHMARK=y
>  CONFIG_XZ_DEC_TEST=m
> -CONFIG_GLOB_SELFTEST=m
> +CONFIG_GLOB_KUNIT_TEST=m

This is not the correct location for CONFIG_GLOB_KUNIT_TEST.
Please run "make savedefconfig" and inspect the resulting defconfig
file.

However, given GLOB_KUNIT_TEST defaults to KUNIT_ALL_TESTS, which
is set to "m" in the m68k defconfigs, there is no need to add
"CONFIG_GLOB_KUNIT_TEST=m" at all.

>  # CONFIG_SECTION_MISMATCH_WARN_ONLY is not set
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_TEST_LOCKUP=m

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds