linux-kernel - Re: [PATCH RESEND] kernel/fork: Update obsolete use_mm references to kthread_use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVz3vlG2PlQ9JX_Z@kernel.org>
Date: Tue, 6 Jan 2026 13:53:34 +0200
From: Mike Rapoport <rppt@...nel.org>
To: "David Hildenbrand (Red Hat)" <david@...nel.org>
Cc: Michal Hocko <mhocko@...e.com>,
	mingzhu.wang(王明珠) <mingzhu.wang@...nssion.com>,
	"kees@...nel.org" <kees@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"dietmar.eggemann@....com" <dietmar.eggemann@....com>,
	"mgorman@...e.de" <mgorman@...e.de>,
	"vbabka@...e.cz" <vbabka@...e.cz>,
	"surenb@...gle.com" <surenb@...gle.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jiazi Li <jqqlijiazi@...il.com>
Subject: Re: [PATCH RESEND] kernel/fork: Update obsolete use_mm references to
 kthread_use_mm

On Tue, Jan 06, 2026 at 10:29:03AM +0100, David Hildenbrand (Red Hat) wrote:
> On 1/6/26 10:26, Michal Hocko wrote:
> > On Tue 06-01-26 07:05:28, mingzhu.wang(王明珠) wrote:
> > > The comment for get_task_mm() in kernel/fork.c incorrectly references the deprecated function `use_mm()`, which has been renamed to `kthread_use_mm()` in kernel/kthread.c.
> > > This patch updates the documentation to reflect the current function names, ensuring accuracy when developers refer to the kernel thread memory context API.
> > > No functional changes were introduced.
> > > 
> > > Signed-off-by: mingzhu.wang <mingzhu.wang@...nssion.com>
> > > ---
> > >   kernel/fork.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/kernel/fork.c b/kernel/fork.c index c4ada32598bd..64e228c541bc 100644
> > > --- a/kernel/fork.c
> > > +++ b/kernel/fork.c
> > > @@ -1312,7 +1312,7 @@ struct file *get_task_exe_file(struct task_struct *task)
> > >    * @task: The task.
> > >    *
> > >    * Returns %NULL if the task has no mm.  Checks PF_KTHREAD (meaning
> > > - * this kernel workthread has transiently adopted a user mm with use_mm,
> > > + * this kernel workthread has transiently adopted a user mm with
> > > + kthread_use_mm,
> > 
> > Please do not wrap the line here.
> 
> But please do so in the patch description, where the maximum should usually
> be 72 characters per line. :)

75 ;-P

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> -- 
> Cheers
> David

-- 
Sincerely yours,
Mike.