linux-kernel - Re: [PATCH 08/11] fs: add support for non-blocking timestamp updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66a15379507f08da9d563416a86d1ad495466ec8.camel@kernel.org>
Date: Tue, 06 Jan 2026 07:13:32 -0500
From: Jeff Layton <jlayton@...nel.org>
To: Christoph Hellwig <hch@....de>, Christian Brauner <brauner@...nel.org>
Cc: Al Viro <viro@...iv.linux.org.uk>, David Sterba <dsterba@...e.com>, Jan
 Kara <jack@...e.cz>, Mike Marshall <hubcap@...ibond.com>, Martin
 Brandenburg	 <martin@...ibond.com>, Carlos Maiolino <cem@...nel.org>,
 Stefan Roesch	 <shr@...com>, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
 Trond Myklebust	 <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, gfs2@...ts.linux.dev,
 io-uring@...r.kernel.org, 	devel@...ts.orangefs.org,
 linux-unionfs@...r.kernel.org, 	linux-mtd@...ts.infradead.org,
 linux-xfs@...r.kernel.org, 	linux-nfs@...r.kernel.org
Subject: Re: [PATCH 08/11] fs: add support for non-blocking timestamp updates

On Tue, 2026-01-06 at 08:50 +0100, Christoph Hellwig wrote:
> Currently file_update_time_flags unconditionally returns -EAGAIN if any
> timestamp needs to be updated and IOCB_NOWAIT is passed.  This makes
> non-blocking direct writes impossible on file systems with granular
> enough timestamps.
> 
> Pass IOCB_NOWAIT to ->update_time and return -EAGAIN if it could block.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  fs/btrfs/inode.c     |  2 ++
>  fs/gfs2/inode.c      |  3 +++
>  fs/inode.c           | 45 +++++++++++++++++++++++++++++++++-----------
>  fs/orangefs/inode.c  |  3 +++
>  fs/overlayfs/inode.c |  2 ++
>  fs/ubifs/file.c      |  3 +++
>  fs/xfs/xfs_iops.c    |  3 +++
>  7 files changed, 50 insertions(+), 11 deletions(-)
> 

LGTM:

Reviewed-by: Jeff Layton <jlayton@...nel.org>