linux-kernel - Re: [PATCH v3] selftests: complete kselftest include centralization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DFHI984SEFV3.2JL88CLHNT2SO@google.com>
Date: Tue, 06 Jan 2026 12:29:08 +0000
From: Brendan Jackman <jackmanb@...gle.com>
To: Bala-Vignesh-Reddy <reddybalavignesh9979@...il.com>, <akpm@...ux-foundation.org>, 
	<shuah@...nel.org>, <richard.weiyang@...il.com>
Cc: <david.shane.hunter@...il.com>, <khalid@...nel.org>, 
	<Liam.Howlett@...cle.com>, <davem@...emloft.net>, <david@...hat.com>, 
	<edumazet@...gle.com>, <gnoack@...gle.com>, <horms@...nel.org>, 
	<kuba@...nel.org>, <linux-kernel@...r.kernel.org>, 
	<linux-kselftest@...r.kernel.org>, <linux-mm@...ck.org>, 
	<linux-security-module@...r.kernel.org>, <lorenzo.stoakes@...cle.com>, 
	<mhocko@...e.com>, <mic@...ikod.net>, <ming.lei@...hat.com>, 
	<pabeni@...hat.com>, <surenb@...gle.com>, <vbabka@...e.cz>, 
	<linux-kernel-mentees@...ts.linux.dev>
Subject: Re: [PATCH v3] selftests: complete kselftest include centralization

On Thu Oct 16, 2025 at 10:44 AM UTC, Bala-Vignesh-Reddy wrote:
> This follow-up patch completes centralization of kselftest.h and
> ksefltest_harness.h includes in remaining seltests files, replacing all
> relative paths with a non-relative paths using shared -I include path
> in lib.mk

This seems to be breaking the x86 build for me:

❯❯  git checkout e6fbd1759c9ece5044d3470f30a5e2166dc9de89
❯❯  make -j mrproper
❯❯  make -sj100 defconfig
❯❯  make -sj100 headers
❯❯  make -sj100 -C tools/testing/selftests  TARGETS="x86"
In file included from syscall_nt.c:17:
helpers.h:10:10: fatal error: kselftest.h: No such file or directory
   10 | #include "kselftest.h"
      |          ^~~~~~~~~~~~~
[...]
❯❯  git checkout HEAD^
❯❯  make -sj100 -C tools/testing/selftests  TARGETS="x86"
[builds]

If I just revert all the changes to tools/testing/selftests/x86/, it
builds again.