linux-kernel - Re: [PATCH net-next, v6] net: mana: Implement ndo_tx_timeout and serialize queue resets per port.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260105173056.7c2c9d0a@kernel.org>
Date: Mon, 5 Jan 2026 17:30:56 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
 decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, longli@...rosoft.com,
 kotaranov@...rosoft.com, horms@...nel.org,
 shradhagupta@...ux.microsoft.com, ssengar@...ux.microsoft.com,
 ernis@...ux.microsoft.com, shirazsaleem@...rosoft.com,
 linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
 dipayanroy@...rosoft.com
Subject: Re: [PATCH net-next, v6] net: mana: Implement ndo_tx_timeout and
 serialize queue resets per port.

On Fri, 2 Jan 2026 20:57:05 -0800 Dipayaan Roy wrote:
> +		apc = netdev_priv(ndev);
> +		disable_work_sync(&apc->queue_reset_work.work);

AI code review points out:

  In mana_remove(), disable_work_sync() is called for each port's
  queue_reset_work. However, when resuming=true, mana_probe() creates a new
  workqueue but does not call mana_probe_port() (which contains INIT_WORK),
  and there is no enable_work() call for queue_reset_work in the resume path.

  The existing link_change_work handles this correctly: it is disabled in
  mana_remove() and re-enabled with enable_work(&ac->link_change_work) in
  mana_probe() when resuming=true.

  Should enable_work(&apc->queue_reset_work.work) be called for each port in
  the resuming path of mana_probe(), similar to how link_change_work is
  handled? Otherwise TX timeout recovery appears to remain disabled after a
  suspend/resume cycle.
-- 
pw-bot: cr