linux-kernel - Re: [PATCH v4 09/25] scsi: ufs: mediatek: Rework the crypt-boost stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8e41f9ecf1231f41f2923099341e4e4c580578b.camel@mediatek.com>
Date: Tue, 6 Jan 2026 13:22:50 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "chu.stanley@...il.com" <chu.stanley@...il.com>, "robh@...nel.org"
	<robh@...nel.org>, Chunfeng Yun (云春峰)
	<Chunfeng.Yun@...iatek.com>, "kishon@...nel.org" <kishon@...nel.org>,
	"James.Bottomley@...senpartnership.com"
	<James.Bottomley@...senpartnership.com>, "bvanassche@....org"
	<bvanassche@....org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>,
	Chaotian Jing (井朝天)
	<Chaotian.Jing@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"nicolas.frattaroli@...labora.com" <nicolas.frattaroli@...labora.com>,
	"vkoul@...nel.org" <vkoul@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "avri.altman@....com"
	<avri.altman@....com>, "broonie@...nel.org" <broonie@...nel.org>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, Louis-Alexis Eyraud
	<louisalexis.eyraud@...labora.com>, "kernel@...labora.com"
	<kernel@...labora.com>
Subject: Re: [PATCH v4 09/25] scsi: ufs: mediatek: Rework the crypt-boost
 stuff

On Mon, 2026-01-05 at 09:05 +0100, Nicolas Frattaroli wrote:
> On Wednesday, 24 December 2025 07:16:34 Central European Standard
> Time Peter Wang (王信友) wrote:
> > On Thu, 2025-12-18 at 13:54 +0100, Nicolas Frattaroli wrote:
> > > -
> > > -static void ufs_mtk_init_boost_crypt(struct ufs_hba *hba)
> > > +static int ufs_mtk_init_boost_crypt(struct ufs_hba *hba)
> > > 
> > 
> > Hi Nicolas,
> > 
> > Please do not change the return type if you are not checking the
> > return
> > value.
> > 
> > 
> > 
> > 
> > Should free the cfg memory?
> 
> It's a devres alloc. It'll get freed on driver removal automatically.
> Freeing it manually would be a double-free once the driver unloads.


Hi Nicolas,

Got it. Please feel free to add my review tag when you correct the
return type.

Thanks.
Peter