linux-kernel - Re: [PATCH v5 06/36] cleanup: Basic compatibility with context analysis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <993d381a-c24e-41d2-a0be-c1b0b5d8cbe9@I-love.SAKURA.ne.jp>
Date: Tue, 6 Jan 2026 22:21:38 +0900
From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To: Marco Elver <elver@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
        Boqun Feng <boqun.feng@...il.com>, Ingo Molnar <mingo@...nel.org>,
        Will Deacon <will@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Chris Li <sparse@...isli.org>, "Paul E. McKenney" <paulmck@...nel.org>,
        Alexander Potapenko <glider@...gle.com>, Arnd Bergmann <arnd@...db.de>,
        Bart Van Assche <bvanassche@....org>, Christoph Hellwig <hch@....de>,
        Dmitry Vyukov <dvyukov@...gle.com>, Eric Dumazet <edumazet@...gle.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Ian Rogers <irogers@...gle.com>, Jann Horn <jannh@...gle.com>,
        Joel Fernandes <joelagnelf@...dia.com>,
        Johannes Berg <johannes.berg@...el.com>,
        Jonathan Corbet <corbet@....net>,
        Josh Triplett <josh@...htriplett.org>,
        Justin Stitt
 <justinstitt@...gle.com>, Kees Cook <kees@...nel.org>,
        Kentaro Takeda <takedakn@...data.co.jp>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Mark Rutland
 <mark.rutland@....com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Miguel Ojeda <ojeda@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
        Neeraj Upadhyay <neeraj.upadhyay@...nel.org>,
        Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>, Thomas Graf <tgraf@...g.ch>,
        Uladzislau Rezki <urezki@...il.com>, Waiman Long <longman@...hat.com>,
        kasan-dev@...glegroups.com, linux-crypto@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-security-module@...r.kernel.org, linux-sparse@...r.kernel.org,
        linux-wireless@...r.kernel.org, llvm@...ts.linux.dev,
        rcu@...r.kernel.org
Subject: Re: [PATCH v5 06/36] cleanup: Basic compatibility with context
 analysis

On 2025/12/20 0:39, Marco Elver wrote:
> Introduce basic compatibility with cleanup.h infrastructure.

Can Compiler-Based Context- and Locking-Analysis work with conditional guards
(unlock only if lock succeeded) ?

I consider that replacing mutex_lock() with mutex_lock_killable() helps reducing
frequency of hung tasks under heavy load where many processes are preempted waiting
for the same mutex to become available (e.g.
https://syzkaller.appspot.com/bug?extid=8f41dccfb6c03cc36fd6 ).

But e.g. commit f49573f2f53e ("tty: use lock guard()s in tty_io") already replaced
plain mutex_lock()/mutex_unlock() with plain guard(mutex). If I propose a patch for
replacing mutex_lock() with mutex_lock_killable(), can I use conditional guards?
(Would be yes if Compiler-Based Context- and Locking-Analysis can work, would be no
 if Compiler-Based Context- and Locking-Analysis cannot work) ?