linux-kernel - Re: [PATCH] RDMA/bng_re: fix variable dereferenced before check in bng_re_net_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMet4B6o-BbUM9RjAHNJXQA32-rvQQ9oaynfZeoSGg+JZkvyaw@mail.gmail.com>
Date: Tue, 6 Jan 2026 19:05:21 +0530
From: Siva Reddy Kallam <siva.kallam@...adcom.com>
To: sunliming@...ux.dev
Cc: gg@...pe.ca, leon@...nel.org, linux-rdma@...r.kernel.org, 
	linux-kernel@...r.kernel.org, sunliming <sunliming@...inos.cn>, 
	kernel test robot <lkp@...el.com>, Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] RDMA/bng_re: fix variable dereferenced before check in bng_re_net_ring_free()

On Tue, Jan 6, 2026 at 5:34 PM <sunliming@...ux.dev> wrote:
>
> From: sunliming <sunliming@...inos.cn>
>
> Fix below smatch warnings:
> drivers/infiniband/hw/bng_re/bng_dev.c:113 bng_re_net_ring_free() warn:
> variable dereferenced before check 'rdev'
>
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Closes: https://lore.kernel.org/r/202601010413.sWadrQel-lkp@intel.com/
> Signed-off-by: sunliming <sunliming@...inos.cn>
> ---
>  drivers/infiniband/hw/bng_re/bng_dev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/bng_re/bng_dev.c b/drivers/infiniband/hw/bng_re/bng_dev.c
> index d8f8d7f7075f..c32395d1593f 100644
> --- a/drivers/infiniband/hw/bng_re/bng_dev.c
> +++ b/drivers/infiniband/hw/bng_re/bng_dev.c
> @@ -118,7 +118,7 @@ static void bng_re_fill_fw_msg(struct bnge_fw_msg *fw_msg, void *msg,
>  static int bng_re_net_ring_free(struct bng_re_dev *rdev,
>                                 u16 fw_ring_id, int type)
>  {
> -       struct bnge_auxr_dev *aux_dev = rdev->aux_dev;
> +       struct bnge_auxr_dev *aux_dev;
>         struct hwrm_ring_free_input req = {};
>         struct hwrm_ring_free_output resp;
>         struct bnge_fw_msg fw_msg = {};
> @@ -127,6 +127,7 @@ static int bng_re_net_ring_free(struct bng_re_dev *rdev,
>         if (!rdev)
>                 return rc;
>
> +       aux_dev = rdev->aux_dev;
rdev is valid from the caller.  NULL check for rdev can be removed. I
need to do few more changes for
addressing  other comments in
https://lore.kernel.org/all/202601010413.sWadrQel-lkp@intel.com/.
I will be pushing a patch soon along with removing if(!rdev). Thanks.

>         if (!aux_dev)
>                 return rc;
>
> --
> 2.25.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5471 bytes)