linux-kernel - Re: [PATCH v2 0/4] HID: asus: Filter HID codes and add WMI fan control for ROG laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3f737f3-05de-4f41-8093-b73f5f3de4b8@gmail.com>
Date: Wed, 7 Jan 2026 14:00:06 +0100
From: Denis Benato <benato.denis96@...il.com>
To: "Ionut Nechita (Sunlight Linux)" <sunlightlinux@...il.com>,
 jikos@...nel.org, bentiss@...nel.org
Cc: superm1@...nel.org, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org, ionut_n2001@...oo.com
Subject: Re: [PATCH v2 0/4] HID: asus: Filter HID codes and add WMI fan
 control for ROG laptops


On 1/7/26 12:19, Ionut Nechita (Sunlight Linux) wrote:
> From: Ionut Nechita <ionut_n2001@...oo.com>
>
> Hi Mario and maintainers,
Hi!

Maintainer of asus-wmi here, thanks a lot for your help!

Thanks Mario for including me too to the party!

A note for the future: from my email client it appears as if you sent
v2 in reply to the previous patch, I have done that on the iio subsystem
and I have been discouraged from doing so because the mail ends up
far from the latest received ones and maintainers are more likely to miss
it. 
> Thank you for the review feedback on v1. I've addressed all the issues:
>
> Changes in v2:
> - Split the monolithic patch into 4 logical patches as requested
> - Fixed include order (linux/acpi.h now before linux/dmi.h)
> - Added #define ASUS_FAN_CTRL_KEY_CODE for 0xae instead of magic number
> - Added #defines for the filtered spurious codes as well for clarity
>
> The patch series now:
> 1. Replaces magic number with existing HID_UP_ASUSVENDOR constant
> 2. Filters spurious HID vendor codes (with proper #defines)
> 3. Adds WMI communication infrastructure
> 4. Implements Fn+F5 fan control key handler (using #define)
>
> This eliminates kernel log spam from unmapped HID codes and enables
> proper fan control functionality on Asus ROG G14/G15 laptops.
>From my notes those unmapped codepages is the embedded controller
echoing out settings for the Windows application armoury-crate to
check if it is still in sync.
> Tested on Asus ROG G14/G15 series laptops.
>
> Ionut Nechita (4):
>   HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant
>   HID: asus: Filter spurious HID vendor codes on ROG laptops
>   HID: asus: Add WMI communication infrastructure
>   HID: asus: Implement Fn+F5 fan control key handler
>
>  drivers/hid/hid-asus.c                     | 60 +++++++++++++++++++++-
>  include/linux/platform_data/x86/asus-wmi.h |  1 +
>  2 files changed, 60 insertions(+), 1 deletion(-)
>